linux-kernel - Re: [PATCH] usb: host: u132-hcd: Remove u132_static_list and list head u132

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 4 Apr 2020 11:23:08 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     madhuparnabhowmik10@...il.com
Cc:     hariprasad.kelam@...il.com, colin.king@...onical.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        ldv-project@...uxtesting.org, andrianov@...ras.ru,
        stern@...land.harvard.edu
Subject: Re: [PATCH] usb: host: u132-hcd: Remove u132_static_list and list
 head u132_list

On Fri, Apr 03, 2020 at 11:48:16PM +0530, madhuparnabhowmik10@...il.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
> 
> u132_static_list is a global list protected by u132_module_lock.
> It is read in the u132_hcd_exit() function without holding the lock
> thus may lead to data race.
> However, it turns out that this list isn't used for anything useful
> and thus it is okay to get rid of it.
> Thus, remove the u132_static_list from u132-hcd module.
> Also remove struct list_head u132_list from struct u132.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Suggested-by: Alan Stern <stern@...land.harvard.edu>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
> ---
>  drivers/usb/host/u132-hcd.c | 10 ----------
>  1 file changed, 10 deletions(-)

Please properly version your patches, otherwise I have no idea what
changed from the previous one, nor do I know which patch to take over
which.

The instructions for how to do this is in the documentation.  Please fix
up and resend so I have a chance to know what to do...

thanks,

greg k-h