linux-kernel - Re: [PATCH v6] crypto: amlogic - Delete duplicate dev_err() in meson_crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 4 Apr 2020 14:00:36 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Tang Bin <tangbin@...s.chinamobile.com>,
        linux-amlogic@...ts.infradead.org, linux-crypto@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Corentin Labbe <clabbe@...libre.com>,
        "David S. Miller" <davem@...emloft.net>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Neil Armstrong <narmstrong@...libre.com>
Subject: Re: [PATCH v6] crypto: amlogic - Delete duplicate dev_err() in
 meson_crypto_probe()

> When something goes wrong, platform_get_irq() will print an error message,

This information is reasonable.


> so in order to avoid the situation of repeat output，

Possible adjustments:
* Separate sentences

* Avoid another typo: “repeated output”


> we should remove dev_err here.

Thus remove a redundant function call.
(An imperative wording is usually preferred for Linux commit messages.)

Regards,
Markus