linux-kernel - Re: [PATCH] ARM: pxa: ssp: Delete an error message in pxa_ssp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 4 Apr 2020 18:17:00 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        Allison Randal <allison@...utok.net>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Enrico Weigelt <lkml@...ux.net>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Russell King <linux@...linux.org.uk>,
        Thomas Gleixner <tglx@...utronix.de>,
        YueHaibing <yuehaibing@...wei.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Tang Bin <tangbin@...s.chinamobile.com>
Subject: Re: [PATCH] ARM: pxa: ssp: Delete an error message in pxa_ssp_probe()

On Sat, Apr 4, 2020 at 5:03 PM Markus Elfring <Markus.Elfring@....de> wrote:
>
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sat, 4 Apr 2020 15:50:10 +0200
> Subject: [PATCH] ARM: pxa: ssp: Delete an error message in pxa_ssp_probe()
>
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.

...

>         ssp->irq = platform_get_irq(pdev, 0);
> -       if (ssp->irq < 0) {
> -               dev_err(dev, "no IRQ resource defined\n");
> +       if (ssp->irq < 0)
>                 return -ENODEV;
> -       }

At the same time we can unshadow the error code, i.e.
  return ssp->irq;


-- 
With Best Regards,
Andy Shevchenko