linux-kernel - Re: [PATCH -next] hv_debugfs: Make hv_debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 4 Apr 2020 17:48:24 +0100
From:   Wei Liu <wei.liu@...nel.org>
To:     Michael Kelley <mikelley@...rosoft.com>
Cc:     YueHaibing <yuehaibing@...wei.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] hv_debugfs: Make hv_debug_root static

On Fri, Apr 03, 2020 at 12:21:47PM +0000, Michael Kelley wrote:
> From: YueHaibing <yuehaibing@...wei.com> Sent: Friday, April 3, 2020 1:29 AM
> > 
> > Fix sparse warning:
> > 
> > drivers/hv/hv_debugfs.c:14:15: warning: symbol 'hv_debug_root' was not declared. Should
> > it be static?
> > 
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> > ---
> >  drivers/hv/hv_debugfs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/hv/hv_debugfs.c b/drivers/hv/hv_debugfs.c
> > index 8a2878573582..ccf752b6659a 100644
> > --- a/drivers/hv/hv_debugfs.c
> > +++ b/drivers/hv/hv_debugfs.c
> > @@ -11,7 +11,7 @@
> > 
> >  #include "hyperv_vmbus.h"
> > 
> > -struct dentry *hv_debug_root;
> > +static struct dentry *hv_debug_root;
> > 
> >  static int hv_debugfs_delay_get(void *data, u64 *val)
> >  {
> > --
> > 2.17.1
> > 
> 
> Reviewed-by:  Michael Kelley <mikelley@...rosoft.com>
> 

Queued. Thanks.