linux-kernel - Re: [PATCH] ata:ahci_xgene:use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 4 Apr 2020 22:58:06 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     唐彬 <tangbin@...s.chinamobile.com>,
        axboe <axboe@...nel.dk>
Cc:     linux-ide <linux-ide@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ata:ahci_xgene:use devm_platform_ioremap_resource() to
 simplify code

Hello!

On 04/01/2020 12:44 PM, 唐彬 wrote:

>         I think the previous code in memory resource #4 to use 'csr' maybe useless，if
> devm_ioremap_resource() failed，the function will return, the 'ctx->csr_mux = csr'  will 
> become useless。So I do the same way as the other three。This's my idea, please criticize
> and correct it。Thank you very much!

   I was unable to understand what you mean here.
   My point is that the driver happily works if the MUX registers do not exist, and your
patch makes the driver fail the probe in this case. Even if this was correct, it's usually
a bad idea to do several thing in the same patch. So, you'd need a patch changing the probing logic before you convert things to devm_platfrom_ioremap_resource()...

[...]

MBR, Sergei