lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 5 Apr 2020 11:16:42 +0200 From: Markus Elfring <Markus.Elfring@....de> To: dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org, linux-imx@....com, kernel@...gutronix.de, Fabio Estevam <festevam@...il.com>, Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...ux.ie>, Philipp Zabel <p.zabel@...gutronix.de>, Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org> Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Tang Bin <tangbin@...s.chinamobile.com> Subject: [PATCH] drm/imx: imx-tve: Delete an error message in imx_tve_bind() From: Markus Elfring <elfring@...rs.sourceforge.net> Date: Sun, 5 Apr 2020 11:01:49 +0200 The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> --- drivers/gpu/drm/imx/imx-tve.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index 5bbfaa2cd0f4..23adbb818d92 100644 --- a/drivers/gpu/drm/imx/imx-tve.c +++ b/drivers/gpu/drm/imx/imx-tve.c @@ -598,10 +598,8 @@ static int imx_tve_bind(struct device *dev, struct device *master, void *data) } irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "failed to get irq\n"); + if (irq < 0) return irq; - } ret = devm_request_threaded_irq(dev, irq, NULL, imx_tve_irq_handler, IRQF_ONESHOT, -- 2.26.0
Powered by blists - more mailing lists