linux-kernel - Re: [PATCH v2] powerpc/powernv: add NULL check after kzalloc in opal_add_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJRQjocOZCqSq+R01ryCVASwdoE0z9+oCn0VupMeWfBiH-sZHw@mail.gmail.com>
Date:   Sun, 5 Apr 2020 20:20:10 +0800
From:   Qiujun Huang <hqjagain@...il.com>
To:     Christophe Leroy <christophe.leroy@....fr>
Cc:     benh@...nel.crashing.org, paulus@...ba.org, mpe@...erman.id.au,
        tglx@...utronix.de, linuxppc-dev@...ts.ozlabs.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] powerpc/powernv: add NULL check after kzalloc in opal_add_one_export

On Sun, Apr 5, 2020 at 8:12 PM Christophe Leroy <christophe.leroy@....fr> wrote:
>
>
>
> Le 05/04/2020 à 12:30, Qiujun Huang a écrit :
> > Here needs a NULL check.
> >
> > Issue found by coccinelle.
> >
> > Signed-off-by: Qiujun Huang <hqjagain@...il.com>
> > ---
> >   arch/powerpc/platforms/powernv/opal.c | 5 ++++-
> >   1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
> > index 2b3dfd0b6cdd..5b98c98817aa 100644
> > --- a/arch/powerpc/platforms/powernv/opal.c
> > +++ b/arch/powerpc/platforms/powernv/opal.c
> > @@ -808,9 +808,12 @@ static int opal_add_one_export(struct kobject *parent, const char *export_name,
> >
> >       rc = of_property_read_u64_array(np, prop_name, &vals[0], 2);
> >       if (rc)
> > -             goto out;
> > +             return rc;
>
> Nice you changed that too.
>
> Then there is no need the initialise attr and name to NULL in their
> declaration, as they won't be used before they are assigned.

So that's it.

>
> >
> >       attr = kzalloc(sizeof(*attr), GFP_KERNEL);
> > +     if (!attr)
> > +             return -ENOMEM;
> > +
> >       name = kstrdup(export_name, GFP_KERNEL);
> >       if (!name) {
> >               rc = -ENOMEM;
> >
>
> Christophe