linux-kernel - Re: [ PATCH stable v4.19] EDAC: Drop per-memory controller buses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5D56C6A7-B076-47BB-9016-7BD54DFE71E7@cisco.com>
Date:   Sun, 5 Apr 2020 18:01:21 +0000
From:   "Manali Shukla (manashuk)" <manashuk@...co.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "bp@...en8.de" <bp@...en8.de>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "xe-linux-external(mailer list)" <xe-linux-external@...co.com>,
        "Borislav Petkov" <bp@...e.de>,
        Aristeu Rozanski Filho <arozansk@...hat.com>,
        "Justin Ernst" <justin.ernst@....com>, Russ Anderson <rja@....com>,
        Tony Luck <tony.luck@...el.com>
Subject: Re: [ PATCH stable v4.19] EDAC: Drop per-memory controller buses

Hi Greg

With this patch , we are removing per-MC bus, this removes dependency on value of max number of controllers (EDAC_MAX_MCS) which is hardcoded to 2 * MAX_NUMNODES  in all stable versions of kernel. 

On two nodes system MAX_NUMNODES value is ‘1’ , so value of max number of memory controller becomes ‘2’, this patch fixes this issue when there are only 2 nodes on the system and number of memory controllers are more than ‘2'

https://lore.kernel.org/linux-edac/20180926152752.GG5584@zn.tnic/

-Manali

On 17/03/20, 3:52 PM, "Greg KH" <gregkh@...uxfoundation.org> wrote:

    On Wed, Mar 11, 2020 at 10:22:01PM -0700, Manali K Shukla wrote:
    > From: Borislav Petkov <bp@...e.de>
    > 
    > upstream 861e6ed667c83d64a42b0db41a22d6b4de4e913f commit
    > 
    > ... and use the single edac_subsys object returned from
    > subsys_system_register(). The idea is to have a single bus
    > and multiple devices on it.
    > 
    > Signed-off-by: Borislav Petkov <bp@...e.de>
    > Acked-by: Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
    > CC: Aristeu Rozanski Filho <arozansk@...hat.com>
    > CC: Greg KH <gregkh@...uxfoundation.org>
    > CC: Justin Ernst <justin.ernst@....com>
    > CC: linux-edac <linux-edac@...r.kernel.org>
    > CC: Mauro Carvalho Chehab <mchehab@...nel.org>
    > CC: Russ Anderson <rja@....com>
    > Cc: Tony Luck <tony.luck@...el.com>
    > Link: https://lkml.kernel.org/r/20180926152752.GG5584@zn.tnic
    > [Manali: backport to v4.19 -stable :
    > - removing per-MC bus, this enables to get rid of memory controllers
    >   maximum number notion
    > - value of max number of memory controllers is 2 * MAX_NUMNODES. On two nodes system MAX_NUMNODES value is ‘1’ and
    >   so value of max number of memory controller becomes ‘2’, this patch fixes this issue when there are only 2 nodes on the system
    >   and number of memory controllers are more than ‘2’]
    > (cherry picked from commit 861e6ed667c83d64a42b0db41a22d6b4de4e913f)
    > Signed-off-by: Manali K Shukla <manashuk@...co.com>
    
    Why is this a patch for the stable trees?  What problem does it solve?
    
    thanks,
    
    greg k-h-