linux-kernel - Re: [PATCH v3] powerpc/powernv: add NULL check after kzalloc in opal_add_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4a96597-6704-3030-b936-6282f0994f09@web.de>
Date:   Sun, 5 Apr 2020 21:06:09 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Qiujun Huang <hqjagain@...il.com>, linuxppc-dev@...ts.ozlabs.org
Cc:     linux-kernel@...r.kernel.org,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Paul Mackerras <paulus@...ba.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v3] powerpc/powernv: add NULL check after kzalloc in
 opal_add_one_export

> Here needs a NULL check.

I find this change description questionable
(despite of a reasonable patch subject).


> Issue found by coccinelle.

Would an information like “Generated by: scripts/coccinelle/null/kmerr.cocci”
be nicer?


> ---

Will a patch change log be helpful here?

Regards,
Markus