linux-kernel - Re: [ PATCH stable v4.19] EDAC: Drop per-memory controller buses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 5 Apr 2020 19:26:01 +0000
From:   "Manali Shukla (manashuk)" <manashuk@...co.com>
To:     Borislav Petkov <bp@...e.de>
CC:     Greg KH <gregkh@...uxfoundation.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "xe-linux-external(mailer list)" <xe-linux-external@...co.com>,
        "Aristeu Rozanski Filho" <arozansk@...hat.com>,
        Justin Ernst <justin.ernst@....com>,
        Russ Anderson <rja@....com>, Tony Luck <tony.luck@...el.com>
Subject: Re: [ PATCH stable v4.19] EDAC: Drop per-memory controller buses

> On 05/04/20, 11:36 PM, "Borislav Petkov" <bp@...e.de> wrote:

>    On Sun, Apr 05, 2020 at 06:01:21PM +0000, Manali Shukla (manashuk) wrote:
>> With this patch , we are removing per-MC bus, this removes dependency on value of max number of controllers (EDAC_MAX_MCS) which is hardcoded to 2 * MAX_NUMNODES  in all stable versions of kernel. 
 >> On two nodes system MAX_NUMNODES value is ‘1’ , so value of max number of memory controller becomes ‘2’, this patch fixes this issue when there are only 2 nodes on the system and number of memory controllers are more than ‘2'
    
 > You basically repeated what you had written already.
    
 >  But what is this fixing? Some platform of yours or what? Why does it
 > need to go to stable?
    
Certain MIPS platform can have 2 nodes and number of memory controllers can be more than '2' .

for above condition, if
#define EDAC_MAX_MCS 2 * MAX_NUMNODES,
it fails in this function edac_mc_add_mc_with_groups
in below condition
if (mci->mc_idx >= EDAC_MAX_MCS) {
pr_warn_once("Too many memory controllers: %d\n", mci->mc_idx);
return -ENODEV;
}
That is why this fix is needed.

 >  Btw, please do not top-post and reply under the quoted text like all of
 > us do.
    
 > Thx.
    
    -- 
 >  Regards/Gruss,
 >   Boris.
    
 >  SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg

Thanks 
Manali