linux-kernel - Re: [PATCH v2] Input: elantech

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR03MB51702AF00C6BA06BBC9F517EE4C50@AM6PR03MB5170.eurprd03.prod.outlook.com>
Date:   Sun, 5 Apr 2020 07:54:39 +0200
From:   Bernd Edlinger <bernd.edlinger@...mail.de>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        "Dave.Wang" <dave.wang@....com.tw>, jingle <jingle.wu@....com.tw>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Enrico Weigelt <info@...ux.net>,
        Allison Randal <allison@...utok.net>,
        Aaron Ma <aaron.ma@...onical.com>
Subject: Re: [PATCH v2] Input: elantech - fix x_max/y_max values

And, furthermore, there is one thing I find really confusing,

I do not see the message v2 quoted below which had an updated commit message,
due to that Benjamin Tissoires request.

It was from my point of view sent on 2/27/20 11:03 PM,
but I cannot find it neither on spinics, nor on marc.info.
That is funny.

Did it reach you guys at all?
Or should I re-send it just in case?


Thanks
Bernd.

On 4/5/20 7:26 AM, Bernd Edlinger wrote:
> Ping...
> 
> This patch works fine for me since several weeks,
> without it I would not be able to use my laptop any more.
> 
> Could you please accept this patch?
> 
> 
> Thanks
> Bernd.
> 
> 
> On 2/27/20 11:03 PM, Bernd Edlinger wrote:
>> Since commit 37548659bb22 ("Input: elantech - query the min/max information beforehand too")
>> moved the querying of the x_max/y_max values from
>> elantech_set_input_params to elantech_query_info,
>> the returned x_max/y_max values are different than before,
>> at least for some firmware versions.
>>
>> The reason is likely that this is now done before
>> elantech_set_absolute_mode does run.  So it may happen that
>> the returned values are exactly half of what they used to be,
>> which makes input_report_abs in PS/2 mode report ABS_X values which
>> exceed the x_max value, which is very annoying since the mouse stops
>> to move then, and ABS_Y value become negative, which is benign.
>>
>> This was observed with a MSI GX70 laptop:
>>
>> elantech: assuming hardware version 3 (with firmware version 0x250f01)
>> elantech: Synaptics capabilities query result 0x18, 0x17, 0x0b.
>> elantech: Elan sample query result 05, 0e, 00
>> input: ETPS/2 Elantech Touchpad as /devices/platform/i8042/serio...
>>
>> Correct this by doubling the returned x_max and y_max
>> value for this specific firmware version.
>>
>> Fixes: 37548659bb22 ("Input: elantech - query the min/max information beforehand too")
>>
>> Signed-off-by: Bernd Edlinger <bernd.edlinger@...mail.de>
>> ---
>>  drivers/input/mouse/elantech.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
>> index 2d8434b..3399db8 100644
>> --- a/drivers/input/mouse/elantech.c
>> +++ b/drivers/input/mouse/elantech.c
>> @@ -1720,6 +1720,10 @@ static int elantech_query_info(struct psmouse *psmouse,
>>  
>>  		info->x_max = (0x0f & param[0]) << 8 | param[1];
>>  		info->y_max = (0xf0 & param[0]) << 4 | param[2];
>> +		if (info->fw_version == 0x250f01) {
>> +			info->x_max <<= 1;
>> +			info->y_max <<= 1;
>> +		}
>>  		break;
>>  
>>  	case 4:
>>