linux-kernel - Re: [PATCH v14 11/14] exfat: add Kconfig and Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Apr 2020 09:27:01 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Namjae Jeon <namjae.jeon@...sung.com>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Linux FS Devel <linux-fsdevel@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Valdis Kletnieks <valdis.kletnieks@...edu>,
        Christoph Hellwig <hch@....de>, sj1557.seo@...sung.com,
        Pali Rohár <pali.rohar@...il.com>,
        Arnd Bergmann <arnd@...db.de>, linkinjeon@...il.com
Subject: Re: [PATCH v14 11/14] exfat: add Kconfig and Makefile

Hi Namjae,

On Mon, Mar 2, 2020 at 7:28 AM Namjae Jeon <namjae.jeon@...sung.com> wrote:
> This adds the Kconfig and Makefile for exfat.
>
> Signed-off-by: Namjae Jeon <namjae.jeon@...sung.com>
> Signed-off-by: Sungjong Seo <sj1557.seo@...sung.com>
> Reviewed-by: Pali Rohár <pali.rohar@...il.com>
> Reviewed-by: Christoph Hellwig <hch@....de>

This is now commit b9d1e2e6265f5dc2 ("exfat: add Kconfig and Makefile").

> --- /dev/null
> +++ b/fs/exfat/Kconfig
> @@ -0,0 +1,21 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +
> +config EXFAT_FS
> +       tristate "exFAT filesystem support"
> +       select NLS
> +       help
> +         This allows you to mount devices formatted with the exFAT file system.
> +         exFAT is typically used on SD-Cards or USB sticks.
> +
> +         To compile this as a module, choose M here: the module will be called
> +         exfat.
> +
> +config EXFAT_DEFAULT_IOCHARSET
> +       string "Default iocharset for exFAT"
> +       default "utf8"
> +       depends on EXFAT_FS
> +       help
> +         Set this to the default input/output character set to use for
> +         converting between the encoding is used for user visible filename and
> +         UTF-16 character that exfat filesystem use, and can be overridden with

exFAT

> +         the "iocharset" mount option for exFAT filesystems.

I think the above paragraph should be reworded.
I tried to do it myself:

          Set this to the default input/output character set to use for
          converting between the encoding that is used for user visible
          filenames, and the UTF-16 character set that the exFAT filesystem
          uses.  This can be overridden with the "iocharset" mount option for
          the exFAT filesystems.

but then I got puzzled by the _3_ encodings that are part of it:
  1. the default input/output character set to use for conversion,
  2. encoding that is used for user visible filenames,
  3. UTF-16 character set that the exFAT filesystem uses.
I assume 1 == 2, but there may be more to it?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds