linux-kernel - Re: [PATCH] vdpa-sim: depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e2ad3e3-c4cb-98cb-e15d-8d9e7aa14f50@redhat.com>
Date:   Mon, 6 Apr 2020 08:34:15 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>, linux-kernel@...r.kernel.org
Cc:     virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH] vdpa-sim: depend on HAS_DMA


On 2020/4/5 下午4:14, Michael S. Tsirkin wrote:
> set_dma_ops isn't available on all architectures:
>
>          make ARCH=um
> ...
>
>     drivers/vdpa/vdpa_sim/vdpa_sim.c: In function 'vdpasim_create':
>>> drivers/vdpa/vdpa_sim/vdpa_sim.c:324:2: error: implicit declaration of function 'set_dma_ops'; did you mean 'set_groups'?
> +[-Werror=implicit-function-declaration]
>       set_dma_ops(dev, &vdpasim_dma_ops);
>       ^~~~~~~~~~~
>       set_groups
>
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> ---
>   drivers/vdpa/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
> index 08b615f2da39..d0cb0e583a5d 100644
> --- a/drivers/vdpa/Kconfig
> +++ b/drivers/vdpa/Kconfig
> @@ -14,7 +14,7 @@ if VDPA_MENU
>   
>   config VDPA_SIM
>   	tristate "vDPA device simulator"
> -	depends on RUNTIME_TESTING_MENU
> +	depends on RUNTIME_TESTING_MENU && HAS_DMA
>   	select VDPA
>   	select VHOST_RING
>   	select VHOST_IOTLB


Acked-by: Jason Wang <jasowang@...hat.com>