linux-kernel - Re: [PATCH v2 7/7] arm64: dts: allwinner: h6: Enable CPU and GPU opp tables for Orange Pi boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJiuCcdhnCLOfe1t7oFWp8KR+_4gZ-eqpZd7zX1O3OO=5ZMB0w@mail.gmail.com>
Date:   Mon, 6 Apr 2020 11:10:06 +0200
From:   Clément Péron <peron.clem@...il.com>
To:     Maxime Ripard <mripard@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        Rob Herring <robh+dt@...nel.org>
Cc:     linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-sunxi <linux-sunxi@...glegroups.com>
Subject: Re: [PATCH v2 7/7] arm64: dts: allwinner: h6: Enable CPU and GPU opp
 tables for Orange Pi boards

Hi,

On Sun, 5 Apr 2020 at 19:36, Clément Péron <peron.clem@...il.com> wrote:
>
> Enable CPU and GPU opp tables for Orange Pi boards.
>
> This needs to change the CPU regulator max voltage to fit
> the OPP table.
>
> Also add the ramp-delay information to avoid any out of spec
> running as the regulator is slower at reaching the voltage
> requested compare to the PLL reaching the frequency.
>
> There is no such information for AXP805 but similar PMIC (AXP813)
> has a DVM (Dynamic Voltage scaling Management) ramp rate equal
> to 2500uV/us.
>
> Signed-off-by: Clément Péron <peron.clem@...il.com>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> index 37f4c57597d4..f3ba500ce4c6 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi

Made a mistake here.
Ondrej Jirman test DVFS on Orange Pi 3 board which is not this device-tree file.

Will fix in V3.

Regards,
Clément

> @@ -5,6 +5,8 @@
>  /dts-v1/;
>
>  #include "sun50i-h6.dtsi"
> +#include "sun50i-h6-cpu-opp.dtsi"
> +#include "sun50i-h6-gpu-opp.dtsi"
>
>  #include <dt-bindings/gpio/gpio.h>
>
> @@ -45,6 +47,10 @@
>         };
>  };
>
> +&cpu0 {
> +       cpu-supply = <&reg_dcdca>;
> +};
> +
>  &ehci0 {
>         status = "okay";
>  };
> @@ -161,7 +167,8 @@
>                         reg_dcdca: dcdca {
>                                 regulator-always-on;
>                                 regulator-min-microvolt = <810000>;
> -                               regulator-max-microvolt = <1080000>;
> +                               regulator-max-microvolt = <1160000>;
> +                               regulator-ramp-delay = <2500>;
>                                 regulator-name = "vdd-cpu";
>                         };
>
> @@ -169,6 +176,7 @@
>                                 regulator-enable-ramp-delay = <32000>;
>                                 regulator-min-microvolt = <810000>;
>                                 regulator-max-microvolt = <1080000>;
> +                               regulator-ramp-delay = <2500>;
>                                 regulator-name = "vdd-gpu";
>                         };
>
> --
> 2.20.1
>