lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 6 Apr 2020 14:25:20 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Michael Straube <straube.linux@...il.com> Cc: gregkh@...uxfoundation.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, Larry.Finger@...inger.net Subject: Re: [PATCH 1/2] staging: rtl8188eu: remove unnecessary asignment On Sun, Apr 05, 2020 at 01:22:29PM +0200, Michael Straube wrote: > Remove unnecessary asignment in SwLedBlink1(). The code path with the > asignment 'pLed->BlinkTimes = 0' is only executed when > 'pLed->BlinkTimes' is already zero and the value is not changed between > the test 'if (pLed->BlinkTimes == 0)' and the asignment. > Better to get rid of the bStopBlinking variable and this becomes more obvious. regards, dan carpenter
Powered by blists - more mailing lists