linux-kernel - RE: [PATCH v2 net] skbuff.h: Improve the checksum related comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <HK0P153MB02738B53E62194DE1AF1752ABFC20@HK0P153MB0273.APCP153.PROD.OUTLOOK.COM>
Date:   Mon, 6 Apr 2020 01:51:35 +0000
From:   Dexuan Cui <decui@...rosoft.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        "willy@...radead.org" <willy@...radead.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "willemb@...gle.com" <willemb@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "simon.horman@...ronome.com" <simon.horman@...ronome.com>,
        "sdf@...gle.com" <sdf@...gle.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "fw@...len.de" <fw@...len.de>,
        "jonathan.lemon@...il.com" <jonathan.lemon@...il.com>,
        "pablo@...filter.org" <pablo@...filter.org>,
        "jeremy@...zel.net" <jeremy@...zel.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 net] skbuff.h: Improve the checksum related comments

> From: Randy Dunlap <rdunlap@...radead.org>
> Sent: Sunday, April 5, 2020 6:43 PM
> On 4/5/20 6:26 PM, Dexuan Cui wrote:
> > @@ -211,9 +211,9 @@
> >   * is implied by the SKB_GSO_* flags in gso_type. Most obviously, if the
> >   * gso_type is SKB_GSO_TCPV4 or SKB_GSO_TCPV6, TCP checksum offload
> as
> >   * part of the GSO operation is implied. If a checksum is being offloaded
> > - * with GSO then ip_summed is CHECKSUM_PARTIAL, csum_start and
> csum_offset
> > - * are set to refer to the outermost checksum being offload (two offloaded
> > - * checksums are possible with UDP encapsulation).
> > + * with GSO then ip_summed is CHECKSUM_PARTIAL, and both csum_start
> and
> > + * csum_offset are set to refer to the outermost checksum being offload
> (two
> 
> 
> being offloaded

Thanks for spotting this! :-)

> 
> Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
> --
> ~Randy

Will post a v3 shortly.

Thanks,
-- Dexuan