linux-kernel - Re: [PATCH] vdpa-sim: depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f4f2502-e810-e87a-2fba-dc887d2f4272@redhat.com>
Date:   Mon, 6 Apr 2020 22:12:56 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>,
        Christoph Hellwig <hch@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH] vdpa-sim: depend on HAS_DMA


On 2020/4/6 下午10:02, Michael S. Tsirkin wrote:
> On Mon, Apr 06, 2020 at 06:09:27AM -0700, Christoph Hellwig wrote:
>> Pleae just drop the code - we should not add new drivers with custom
>> DMA ops.
> I'm not sure there's another way to do this: this not a driver, it's a
> software emulator that pretends to be an actual device. We can't
> have the platform supply DMA ops here since the platform is a regular
> x86 or whatever.


Yes, actually vdpa-sim does not depends on HAS_DMA. Maybe we can do 
shortcut like dev->dma_ops = vdpasim_dma_ops;

Thanks


>