linux-kernel - Re: [PATCH v2 0/5] KVM: s390: vsie: fixes and cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Apr 2020 18:06:41 +0200
From:   Christian Borntraeger <borntraeger@...ibm.com>
To:     David Hildenbrand <david@...hat.com>, kvm@...r.kernel.org
Cc:     linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Cornelia Huck <cohuck@...hat.com>,
        Janosch Frank <frankja@...ux.ibm.com>
Subject: Re: [PATCH v2 0/5] KVM: s390: vsie: fixes and cleanups

Series applied. thanks. 
I will schedule the first 3 for master, 4 and 5 for next.


On 03.04.20 17:30, David Hildenbrand wrote:
> Some vsie/gmap fixes and two cleanups/improvements.
> 
> Patch #1 fixes an issue reported by Janosch. It was never observed so far,
> because KVM usually doesn't use a region 1 table for it's guest (unless
> memory would be exceeding something like 16 EB, which isn't even supported
> by the HW). Older QEMU+KVM or other hypervisors can trigger this.
> 
> Patch #2 fixes a code path that probably was never taken and will most
> probably not be taken very often in the future - unless somebody really
> messes up the page tables for a guest (or writes a test for it). At some
> point, a test case for this would be nice.
> 
> Patch #3 fixes a rare possible race. Don't think this is stable material.
> 
> Gave it some testing with my limited access to somewhat-fast s390x
> machines. Booted a Linux kernel, supplying all possible number of
> page table hiearchies.
> 
> v1 -> v2:
> - "KVM: s390: vsie: Fix region 1 ASCE sanity shadow address checks"
> -- Fix WARN_ON_ONCE
> - "gmap_table_walk() simplifications"
> -- Also init "table" directly
> 
> David Hildenbrand (5):
>   KVM: s390: vsie: Fix region 1 ASCE sanity shadow address checks
>   KVM: s390: vsie: Fix delivery of addressing exceptions
>   KVM: s390: vsie: Fix possible race when shadowing region 3 tables
>   KVM: s390: vsie: Move conditional reschedule
>   KVM: s390: vsie: gmap_table_walk() simplifications
> 
>  arch/s390/kvm/vsie.c |  4 ++--
>  arch/s390/mm/gmap.c  | 17 +++++++++++------
>  2 files changed, 13 insertions(+), 8 deletions(-)
>