linux-kernel - Re: [RESEND PATCH v2] dt-bindings: bd718x7: Yamlify and add BD71850

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5963a34e3ebaada7cc6ec786f6f2342a7cc2a15c.camel@fi.rohmeurope.com>
Date:   Mon, 6 Apr 2020 05:10:27 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "robh+dt@...nel.org" <robh+dt@...nel.org>
CC:     "mazziesaccount@...il.com" <mazziesaccount@...il.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>
Subject: Re: [RESEND PATCH v2] dt-bindings: bd718x7: Yamlify and add BD71850

Morning Rob & Lee,

Lee already applied this to for-mfd-next. (The driver changes with
BD71850 compatible addition went in his tree too). I guess the right
thing to do is to send him an incremental patch for his for-mfd-next
branch? I'll do that - sorry for the trouble.

Best Regards,
	Matti

On Sat, 2020-04-04 at 11:30 -0600, Rob Herring wrote:
> On Sat, Apr 4, 2020 at 11:28 AM Rob Herring <robh+dt@...nel.org>
> wrote:
> > On Fri, Mar 20, 2020 at 3:42 AM Matti Vaittinen
> > <matti.vaittinen@...rohmeurope.com> wrote:
> > > Convert ROHM bd71837 and bd71847 PMIC binding text docs to yaml.
> > > Split
> > > the binding document to two separate documents (own documents for
> > > BD71837
> > > and BD71847) as they have different amount of regulators. This
> > > way we can
> > > better enforce the node name check for regulators. ROHM is also
> > > providing
> > > BD71850 - which is almost identical to BD71847 - main difference
> > > is some
> > > initial regulator states. The BD71850 can be driven by same
> > > driver and it
> > > has same buck/LDO setup as BD71847 - add it to BD71847 binding
> > > document and
> > > introduce compatible for it.
> > > 
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com
> > > >
> > > Reviewed-by: Rob Herring <robh@...nel.org>
> > 
> > I did, but there's some dtc warnings that need to be fixed:
> > 
> > Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dts:23.17-30:
> > Warning (reg_format): /example-0/i2c/pmic@4b:reg: property has
> > invalid
> > length (4 bytes) (#address-cells == 2, #size-cells == 1)
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dt.yaml:
> > Warning (pci_device_reg): Failed prerequisite 'reg_format'
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dt.yaml:
> > Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dt.yaml:
> > Warning (simple_bus_reg): Failed prerequisite 'reg_format'
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dts:20.13-131.11:
> > Warning (i2c_bus_bridge): /example-0/i2c: incorrect #address-cells
> > for
> > I2C bus
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dts:20.13-131.11:
> > Warning (i2c_bus_bridge): /example-0/i2c: incorrect #size-cells for
> > I2C bus
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dt.yaml:
> > Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dt.yaml:
> > Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge'
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dt.yaml:
> > Warning (spi_bus_reg): Failed prerequisite 'reg_format'
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dts:21.25-130.15:
> > Warning (avoid_default_addr_size): /example-0/i2c/pmic@4b: Relying
> > on
> > default #address-cells value
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dts:21.25-130.15:
> > Warning (avoid_default_addr_size): /example-0/i2c/pmic@4b: Relying
> > on
> > default #size-cells value
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dt.yaml:
> > Warning (unique_unit_address): Failed prerequisite
> > 'avoid_default_addr_size'
> 
> And also:
> 
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dts:23.17-30:
> Warning (reg_format): /example-0/i2c/pmic@4b:reg: property has
> invalid
> length (4 bytes) (#address-cells == 2, #size-cells == 1)
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dt.yaml:
> Warning (pci_device_reg): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dt.yaml:
> Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dt.yaml:
> Warning (simple_bus_reg): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dts:20.13-112.11:
> Warning (i2c_bus_bridge): /example-0/i2c: incorrect #address-cells
> for
> I2C bus
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dts:20.13-112.11:
> Warning (i2c_bus_bridge): /example-0/i2c: incorrect #size-cells for
> I2C bus
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dt.yaml:
> Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dt.yaml:
> Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge'
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dt.yaml:
> Warning (spi_bus_reg): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dts:21.25-111.15:
> Warning (avoid_default_addr_size): /example-0/i2c/pmic@4b: Relying on
> default #address-cells value
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dts:21.25-111.15:
> Warning (avoid_default_addr_size): /example-0/i2c/pmic@4b: Relying on
> default #size-cells value
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dt.yaml:
> Warning (unique_unit_address): Failed prerequisite
> 'avoid_default_addr_size'

I believe these were already applied by Lee.