linux-kernel - Re: [PATCHv2 1/8] khugepaged: Add self test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71529d58-e51d-4f36-037d-42e60dd5a8ff@nvidia.com>
Date:   Mon, 6 Apr 2020 11:53:56 -0700
From:   Ralph Campbell <rcampbell@...dia.com>
To:     "Kirill A. Shutemov" <kirill@...temov.name>,
        <akpm@...ux-foundation.org>, Andrea Arcangeli <aarcange@...hat.com>
CC:     Zi Yan <ziy@...dia.com>, Yang Shi <yang.shi@...ux.alibaba.com>,
        <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Subject: Re: [PATCHv2 1/8] khugepaged: Add self test


On 4/3/20 4:29 AM, Kirill A. Shutemov wrote:
> The test checks if khugepaged is able to recover huge page where we
> expetect to do so. It only covers anon-THP for now.
> 
> Currenlty the test shows few failures. They are going to be addressed by
> the following patches.
> 
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

One minor nit below but otherwise looks OK.
Reviewed-by: Ralph Campbell <rcampbell@...dia.com>


> +
> +static void collapse_signle_pte_entry(void)
> +{

Shouldn't this be collapse_single_pte_entry()?
(and change the places where it is called)