linux-kernel - Re: [PATCH] libbpf: Initialize *nl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <977ea25b-01bc-c1aa-eb93-e51ff916da0f@iogearbox.net>
Date:   Mon, 6 Apr 2020 22:14:45 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jeremy Cline <jcline@...hat.com>,
        Alexei Starovoitov <ast@...nel.org>
Cc:     Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>,
        Yonghong Song <yhs@...com>, Andrii Nakryiko <andriin@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libbpf: Initialize *nl_pid so gcc 10 is happy

On 4/4/20 7:14 AM, Jeremy Cline wrote:
> Builds of Fedora's kernel-tools package started to fail with "may be
> used uninitialized" warnings for nl_pid in bpf_set_link_xdp_fd() and
> bpf_get_link_xdp_info() on the s390 architecture.
> 
> Although libbpf_netlink_open() always returns a negative number when it
> does not set *nl_pid, the compiler does not determine this and thus
> believes the variable might be used uninitialized. Assuage gcc's fears
> by explicitly initializing nl_pid.
> 
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1807781
> Signed-off-by: Jeremy Cline <jcline@...hat.com>

Applied, thanks!