linux-kernel - Re: [PATCH] scsi: Remove unnecessary calls to memset after dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <807090f6-f2ee-0e5b-6e35-b0c148c7a22f@web.de>
Date:   Tue, 7 Apr 2020 18:56:28 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Alex Dewar <alex.dewar@....co.uk>
Cc:     Allison Randal <allison@...utok.net>,
        Arnd Bergmann <arnd@...db.de>,
        Julia Lawall <julia.lawall@...ia.fr>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Himanshu Madhani <hmadhani@...vell.com>,
        "James E. J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Richard Fontana <rfontana@...hat.com>,
        Sathya Prakash <sathya.prakash@...adcom.com>,
        Suganath Prabu Subramani 
        <suganath-prabu.subramani@...adcom.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-scsi@...r.kernel.org, aacraid@...rosemi.com,
        MPT-FusionLinux.pdl@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: Remove unnecessary calls to memset after
 dma_alloc_coherent

>> …
>>> +++ b/drivers/scsi/qla2xxx/qla_mbx.c
>>> @@ -4887,15 +4887,13 @@ qla25xx_set_els_cmds_supported(scsi_qla_host_t *vha)
>>>  	    "Entered %s.\n", __func__);
>>>
>>>  	els_cmd_map = dma_alloc_coherent(&ha->pdev->dev, ELS_CMD_MAP_SIZE,
>>> -	    &els_cmd_map_dma, GFP_KERNEL);
>>> +					 &els_cmd_map_dma, GFP_KERNEL);
>>>  	if (!els_cmd_map) {
>> …
>>
>> I find it safer to integrate such source code reformattings by
>> another update step which will be separated from the proposed deletion
>> of unwanted function calls.
>
> Good point. This whitespace was autoformatted by Coccinelle,
> probably due to my bad SmPL skills.

Some system factors can be involved here.

* The source code formatting can occasionally be improvable
  in further ways (despite of help by a software like Coccinelle).

* A change mixture can become more challenging.

* Would you like to extend your skills in corresponding areas anyhow?

Regards,
Markus