linux-kernel - Re: get_maintainer.pl sends bogus addresses to git send-email

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e6975d606846c834a387c07ee11cdce52356586.camel@perches.com>
Date:   Tue, 07 Apr 2020 10:18:41 -0700
From:   Joe Perches <joe@...ches.com>
To:     Jeff King <peff@...f.net>, Olaf Hering <olaf@...fle.de>
Cc:     linux-kernel@...r.kernel.org, git@...r.kernel.org
Subject: Re: get_maintainer.pl sends bogus addresses to git send-email

On Tue, 2020-04-07 at 13:02 -0400, Jeff King wrote:
> On Tue, Apr 07, 2020 at 05:40:46PM +0200, Olaf Hering wrote:
> 
> > For me sending patches via git send-email fails because email address
> > conversion is failing. Something appends a ')' to x86/lkml@...nel.org.
> > I suspect the double '))' in MAINTAINERS is confusing the command.
> > I tried to send the trivial patch from v5.0 and v5.6 tag.
> > 
> > Is this a failure in ./scripts/get_maintainer.pl,
> > or is this something git does internally?
> > I'm sure others use such command on a daily basis, so likely something on
> > my end became broken at some point in the past.
> 
> It's a bug in send-email's hand-rolled address parser, which was fixed
> in bd869f67b9 (send-email: add and use a local copy of Mail::Address,
> 2018-01-05). Upgrade to Git v2.17.0 or newer.

Not really.
You need to add --norolestats on the get_maintainer command line

git send-email expects bare email addresses, not ones annotated
with additional content.


For instance:

$ ./scripts/get_maintainer.pl -f lib/vsprintf.c
Petr Mladek <pmladek@...e.com> (maintainer:VSPRINTF)
Steven Rostedt <rostedt@...dmis.org> (maintainer:VSPRINTF)
Sergey Senozhatsky <sergey.senozhatsky@...il.com> (maintainer:VSPRINTF)
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> (reviewer:VSPRINTF)
Rasmus Villemoes <linux@...musvillemoes.dk> (reviewer:VSPRINTF)
linux-kernel@...r.kernel.org (open list)

vs:

$ ./scripts/get_maintainer.pl -f --norolestats lib/vsprintf.c
Petr Mladek <pmladek@...e.com>
Steven Rostedt <rostedt@...dmis.org>
Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Rasmus Villemoes <linux@...musvillemoes.dk>
linux-kernel@...r.kernel.org