linux-kernel - Re: [PATCH] checkpatch: Fix a typo in the regex for $allocFunctions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ffdaa916088c95a984b2953334ea446251b2ecd9.camel@perches.com>
Date:   Tue, 07 Apr 2020 12:03:52 -0700
From:   Joe Perches <joe@...ches.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        apw@...onical.com, Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Fix a typo in the regex for $allocFunctions

On Tue, 2020-04-07 at 21:00 +0200, Christophe JAILLET wrote:
> Here, we look for function such as 'netdev_alloc_skb_ip_align', so a '_'
> is missing in the regex.
> 
> To make sure:
>    grep -r --include=*.c skbip_a * | wc   ==>   0 results
>    grep -r --include=*.c skb_ip_a * | wc  ==> 112 results

Acked-by: Joe Perches <joe@...ches.com>

> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 529c892722b9..c392ab8ea12e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -479,7 +479,7 @@ our $allocFunctions = qr{(?x:
>  		(?:kv|k|v)[czm]alloc(?:_node|_array)? |
>  		kstrdup(?:_const)? |
>  		kmemdup(?:_nul)?) |
> -	(?:\w+)?alloc_skb(?:ip_align)? |
> +	(?:\w+)?alloc_skb(?:_ip_align)? |
>  				# dev_alloc_skb/netdev_alloc_skb, et al
>  	dma_alloc_coherent
>  )};