Message-ID: <20200407201258.GB28801@ravnborg.org>
Date:   Tue, 7 Apr 2020 22:12:58 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Jagan Teki <jagan@...rulasolutions.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org, David Airlie <airlied@...ux.ie>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-amarula@...rulasolutions.com
Subject: Re: [PATCH v3 1/3] dt-bindings: display: panel: Convert feiyang,
 fy07024di26a30d to DT schema

Hi Jagan.

On Fri, Apr 03, 2020 at 07:54:51PM +0530, Jagan Teki wrote:
> Convert the feiyang,fy07024di26a30d panel bindings to DT schema.
> 
> Signed-off-by: Jagan Teki <jagan@...rulasolutions.com>

Thanks, this and the two other patches are now pushed to drm-misc-next.

	Sam

> ---
> Changes for v3:
> - update the licence, used (GPL-2.0-only OR BSD-2-Clause) since
>   I'm the author for old binding
> - use panel-common.yaml
> - mark true for common properties 
> - use maxItems: 1 for reg
> - update example
> Changes for v2:
> - fix dt_binding_check 
> 
>  .../display/panel/feiyang,fy07024di26a30d.txt | 20 -------
>  .../panel/feiyang,fy07024di26a30d.yaml        | 58 +++++++++++++++++++
>  2 files changed, 58 insertions(+), 20 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
>  create mode 100644 Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
> deleted file mode 100644
> index 82caa7b65ae8..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -Feiyang FY07024DI26A30-D 7" MIPI-DSI LCD Panel
> -
> -Required properties:
> -- compatible: must be "feiyang,fy07024di26a30d"
> -- reg: DSI virtual channel used by that screen
> -- avdd-supply: analog regulator dc1 switch
> -- dvdd-supply: 3v3 digital regulator
> -- reset-gpios: a GPIO phandle for the reset pin
> -
> -Optional properties:
> -- backlight: phandle for the backlight control.
> -
> -panel@0 {
> -	compatible = "feiyang,fy07024di26a30d";
> -	reg = <0>;
> -	avdd-supply = <&reg_dc1sw>;
> -	dvdd-supply = <&reg_dldo2>;
> -	reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */
> -	backlight = <&backlight>;
> -};
> diff --git a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
> new file mode 100644
> index 000000000000..95acf9e96f1c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/feiyang,fy07024di26a30d.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Feiyang FY07024DI26A30-D 7" MIPI-DSI LCD Panel
> +
> +maintainers:
> +  - Jagan Teki <jagan@...rulasolutions.com>
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: feiyang,fy07024di26a30d
> +
> +  reg:
> +    description: DSI virtual channel used by that screen
> +    maxItems: 1
> +
> +  avdd-supply:
> +    description: analog regulator dc1 switch
> +
> +  dvdd-supply:
> +    description: 3v3 digital regulator
> +
> +  reset-gpios: true
> +
> +  backlight: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - avdd-supply
> +  - dvdd-supply
> +  - reset-gpios
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    dsi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@0 {
> +            compatible = "feiyang,fy07024di26a30d";
> +            reg = <0>;
> +            avdd-supply = <&reg_dc1sw>;
> +            dvdd-supply = <&reg_dldo2>;
> +            reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */
> +            backlight = <&backlight>;
> +        };
> +    };
> -- 
> 2.17.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Powered by blists - more mailing lists