linux-kernel - Re: [PATCH v2 1/4] dt-bindings: Add Broadcom STB USB support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Apr 2020 13:28:11 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Rob Herring <robh@...nel.org>, Al Cooper <alcooperx@...il.com>
Cc:     linux-kernel@...r.kernel.org, andriy.shevchenko@...ux.intel.com,
        Alan Stern <stern@...land.harvard.edu>,
        bcm-kernel-feedback-list@...adcom.com,
        Chunfeng Yun <chunfeng.yun@...iatek.com>,
        devicetree@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jonathan Neuschäfer <j.neuschaefer@....net>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-usb@...r.kernel.org, Mark Rutland <mark.rutland@....com>,
        Mathias Nyman <mathias.nyman@...el.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: Add Broadcom STB USB support

On 3/30/2020 8:40 AM, Rob Herring wrote:
> On Fri, 27 Mar 2020 16:47:08 -0400, Al Cooper wrote:
>> Add DT bindings for Broadcom STB USB EHCI and XHCI drivers.
>>
>> NOTE: The OHCI driver is not included because it uses the generic
>>       platform driver.
>>
>> Signed-off-by: Al Cooper <alcooperx@...il.com>
>> ---
>>  .../bindings/usb/brcm,bcm7445-ehci.yaml       | 61 +++++++++++++++++++
>>  .../devicetree/bindings/usb/usb-xhci.txt      |  1 +
>>  2 files changed, 62 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml
>>
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.example.dt.yaml: ehci@...00300: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+'

This warning does not seem to be legitimate, the 'interrupt-names'
property is a valid one, where do we update the schema such that it
knows about it?

> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.example.dt.yaml: ehci@...00300: $nodename:0: 'ehci@...00300' does not match '^usb(@.*)?'

This one is a legitimate one and should be fixed.
--
Florian