linux-kernel - Re: [PATCH] USB: mtu3: Use the correct style for SPDX License Identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1586230628.28772.8.camel@mhfsdcap03>
Date:   Tue, 7 Apr 2020 11:37:08 +0800
From:   Chunfeng Yun <chunfeng.yun@...iatek.com>
To:     Nishad Kamdar <nishadkamdar@...il.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Uwe Kleine-König" 
        <u.kleine-koenig@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Joe Perches <joe@...ches.com>, <linux-usb@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB: mtu3: Use the correct style for SPDX License
 Identifier

On Sat, 2020-04-04 at 16:07 +0530, Nishad Kamdar wrote:
> This patch corrects the SPDX License Identifier style in
> header files related to MediaTek USB3 Dual Role controller.
> For C header files Documentation/process/license-rules.rst
> mandates C-like comments (opposed to C source files where
> C++ style should be used).
> 
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
> 
> Suggested-by: Joe Perches <joe@...ches.com>
> Signed-off-by: Nishad Kamdar <nishadkamdar@...il.com>
> ---
>  drivers/usb/mtu3/mtu3.h         | 2 +-
>  drivers/usb/mtu3/mtu3_debug.h   | 2 +-
>  drivers/usb/mtu3/mtu3_dr.h      | 2 +-
>  drivers/usb/mtu3/mtu3_hw_regs.h | 2 +-
>  drivers/usb/mtu3/mtu3_qmu.h     | 2 +-
>  drivers/usb/mtu3/mtu3_trace.h   | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/usb/mtu3/mtu3.h b/drivers/usb/mtu3/mtu3.h
> index 6087be236a35..d49db92ab26c 100644
> --- a/drivers/usb/mtu3/mtu3.h
> +++ b/drivers/usb/mtu3/mtu3.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0 */
>  /*
>   * mtu3.h - MediaTek USB3 DRD header
>   *
> diff --git a/drivers/usb/mtu3/mtu3_debug.h b/drivers/usb/mtu3/mtu3_debug.h
> index e96a69234d05..fb6b28277c9b 100644
> --- a/drivers/usb/mtu3/mtu3_debug.h
> +++ b/drivers/usb/mtu3/mtu3_debug.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0 */
>  /*
>   * mtu3_debug.h - debug header
>   *
> diff --git a/drivers/usb/mtu3/mtu3_dr.h b/drivers/usb/mtu3/mtu3_dr.h
> index 5e58c4dbd54a..760fe7d69c6b 100644
> --- a/drivers/usb/mtu3/mtu3_dr.h
> +++ b/drivers/usb/mtu3/mtu3_dr.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0 */
>  /*
>   * mtu3_dr.h - dual role switch and host glue layer header
>   *
> diff --git a/drivers/usb/mtu3/mtu3_hw_regs.h b/drivers/usb/mtu3/mtu3_hw_regs.h
> index 8382d066749e..bf34f784f84b 100644
> --- a/drivers/usb/mtu3/mtu3_hw_regs.h
> +++ b/drivers/usb/mtu3/mtu3_hw_regs.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0 */
>  /*
>   * mtu3_hw_regs.h - MediaTek USB3 DRD register and field definitions
>   *
> diff --git a/drivers/usb/mtu3/mtu3_qmu.h b/drivers/usb/mtu3/mtu3_qmu.h
> index 9cfde201db63..66e1c0ab5a99 100644
> --- a/drivers/usb/mtu3/mtu3_qmu.h
> +++ b/drivers/usb/mtu3/mtu3_qmu.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0 */
>  /*
>   * mtu3_qmu.h - Queue Management Unit driver header
>   *
> diff --git a/drivers/usb/mtu3/mtu3_trace.h b/drivers/usb/mtu3/mtu3_trace.h
> index 050e30f0fbd4..1b897636daf2 100644
> --- a/drivers/usb/mtu3/mtu3_trace.h
> +++ b/drivers/usb/mtu3/mtu3_trace.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0 */
>  /**
>   * mtu3_trace.h - trace support
>   *

Reviewed-by: Chunfeng Yun <chunfeng.yun@...iatek.com>

Thanks