linux-kernel - Re: [v2] iio: core: move 'indio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a1ae5805-6576-82cf-33c0-6fc4fd3512d8@web.de>
Date:   Tue, 7 Apr 2020 14:12:51 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>,
        linux-iio@...r.kernel.org
Cc:     Jonathan Cameron <jic23@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [v2] iio: core: move 'indio_dev->info' null check first

>     Doesn't fix anything.

You would like to change something for a specific reason.
Thus please omit this sentence.

>     Just moves this to be the first check, as it's very …

Wording alternative:
Move a null pointer check to the beginning of this function implementation.

>     This is a minor optimization, since '__iio_device_register()' will waste
>     fewer validation cycles in case 'indio_dev->info' is NULL.

How do you think about to use the text “iio: core: Improve input parameter validation
in __iio_device_register()” as a commit subject?

Regards,
Markus