linux-kernel - Re: [PATCH V2 1/9] objtool: Introduce HINT_RET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21e4ab99-fe75-ff0d-3c7e-cee0fbe95104@oracle.com>
Date:   Tue, 7 Apr 2020 15:17:28 +0200
From:   Alexandre Chartre <alexandre.chartre@...cle.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org, jpoimboe@...hat.com,
        jthierry@...hat.com, tglx@...utronix.de
Subject: Re: [PATCH V2 1/9] objtool: Introduce HINT_RET_OFFSET


On 4/7/20 2:53 PM, Peter Zijlstra wrote:
> On Tue, Apr 07, 2020 at 09:31:34AM +0200, Alexandre Chartre wrote:
>> diff --git a/tools/objtool/check.h b/tools/objtool/check.h
>> index 6d875ca6fce0..7a91497fee7e 100644
>> --- a/tools/objtool/check.h
>> +++ b/tools/objtool/check.h
>> @@ -33,9 +33,12 @@ struct instruction {
>>   	unsigned int len;
>>   	enum insn_type type;
>>   	unsigned long immediate;
>> -	bool alt_group, dead_end, ignore, hint, save, restore, ignore_alts;
>> +	unsigned int alt_group;
> 
> ^^ that wants to be in a later patch I'm thinking

Correct, rebase error, should be in patch 4.

Thanks,

alex.

>> +	bool dead_end, ignore, ignore_alts;
>> +	bool hint, save, restore;
>>   	bool retpoline_safe;
>>   	u8 visited;
>> +	u8 ret_offset;
>>   	struct symbol *call_dest;
>>   	struct instruction *jump_dest;
>>   	struct instruction *first_jump_src;
>> -- 
>> 2.18.2
>>