lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 7 Apr 2020 17:28:19 +0200 From: Oscar Carter <oscar.carter@....com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Oscar Carter <oscar.carter@....com>, devel@...verdev.osuosl.org, Malcolm Priestley <tvboxspy@...il.com>, linux-kernel@...r.kernel.org, Forest Bond <forest@...ttletooquiet.net>, Dan Carpenter <dan.carpenter@...cle.com> Subject: Re: [PATCH 2/3] staging: vt6656: Use define instead of magic number for tx_rate On Mon, Apr 06, 2020 at 07:58:08PM +0200, Greg Kroah-Hartman wrote: > On Mon, Apr 06, 2020 at 06:38:36PM +0200, Oscar Carter wrote: > > On Mon, Apr 06, 2020 at 04:22:12PM +0200, Greg Kroah-Hartman wrote: > > > On Sat, Apr 04, 2020 at 04:13:59PM +0200, Oscar Carter wrote: > > > > Use the define RATE_11M present in the file "device.h" instead of the > > > > magic number 3. So the code is more clear. > > > > > > > > Signed-off-by: Oscar Carter <oscar.carter@....com> > > > > Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com> > > > > --- > > > > drivers/staging/vt6656/baseband.c | 3 ++- > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/staging/vt6656/baseband.c b/drivers/staging/vt6656/baseband.c > > > > index 3e4bd637849a..a785f91c1566 100644 > > > > --- a/drivers/staging/vt6656/baseband.c > > > > +++ b/drivers/staging/vt6656/baseband.c > > > > @@ -24,6 +24,7 @@ > > > > > > > > #include <linux/bits.h> > > > > #include <linux/kernel.h> > > > > +#include "device.h" > > > > #include "mac.h" > > > > #include "baseband.h" > > > > #include "rf.h" > > > > @@ -141,7 +142,7 @@ unsigned int vnt_get_frame_time(u8 preamble_type, u8 pkt_type, > > > > > > > > rate = (unsigned int)vnt_frame_time[tx_rate]; > > > > > > > > - if (tx_rate <= 3) { > > > > + if (tx_rate <= RATE_11M) { > > > > if (preamble_type == 1) > > > > preamble = 96; > > > > else > > > > -- > > > > 2.20.1 > > > > > > This doesn't apply to my tree :( > > > > > Sorry, but I don't understand what it means. This meant that I need to rebase > > this patch against your staging-next branch of your staging tree ? > > Yes, and 3/3 as well, because I dropped the 1/3 patch here. > Ok, I will create a new patch series version rebased against your staging-next branch and I will send it. > thanks, > > greg k-h thanks, oscar carter
Powered by blists - more mailing lists