linux-kernel - Re: [PATCH 3/4] x86,module: Detect VMX vs SLD conflicts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200408085947.c48be95995fb6915bf16de88@kernel.org>
Date:   Wed, 8 Apr 2020 08:59:47 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Andrew Cooper <andrew.cooper3@...rix.com>
Cc:     Peter Zijlstra <peterz@...radead.org>, <tglx@...utronix.de>,
        <linux-kernel@...r.kernel.org>, <hch@...radead.org>,
        <sean.j.christopherson@...el.com>, <mingo@...hat.com>,
        <bp@...en8.de>, <hpa@...or.com>, <x86@...nel.org>,
        <kenny@...ix.com>, <jeyu@...nel.org>, <rasmus.villemoes@...vas.dk>,
        <pbonzini@...hat.com>, <fenghua.yu@...el.com>,
        <xiaoyao.li@...el.com>, <nadav.amit@...il.com>,
        <thellstrom@...are.com>, <tony.luck@...el.com>,
        <rostedt@...dmis.org>, <gregkh@...uxfoundation.org>,
        <jannh@...gle.com>, <keescook@...omium.org>,
        <David.Laight@...lab.com>, <dcovelli@...are.com>
Subject: Re: [PATCH 3/4] x86,module: Detect VMX vs SLD conflicts

Hi Andrew,

On Tue, 7 Apr 2020 18:16:58 +0100
Andrew Cooper <andrew.cooper3@...rix.com> wrote:

> On 07/04/2020 17:51, Masami Hiramatsu wrote:
> > diff --git a/tools/arch/x86/tools/gen-insn-attr-x86.awk b/tools/arch/x86/tools/gen-insn-attr-x86.awk
> > index d74d9e605723..ade80796453c 100644
> > --- a/tools/arch/x86/tools/gen-insn-attr-x86.awk
> > +++ b/tools/arch/x86/tools/gen-insn-attr-x86.awk
> > @@ -70,6 +70,8 @@ BEGIN {
> >  	mmx_expr = "^(emms|fxsave|fxrstor|ldmxcsr|stmxcsr)" # MMX/SSE nmemonics lacking operands
> >  	fpu_expr = "^x87"
> >  
> > +	vmx_expr = "^VM.*" # All mnemonic start with "VM" are VMX instructions
> 
> Not really.
> 
> VMMCALL, VMLOAD, VMSAVE and VMRUN are SVM instructions.

Here VMX will include SVM instructions. Would we need to distinguish them in this context?
(Or INAT_VIRT might be politically correct :) )

> VMASKMOV is a AVX instruction.

Good point. That instruction is written in lowercase "vmaskmov" in x86-opcode-map.txt.
(Maybe it is better to note it in x86-opcode-map.txt)

Thank you,

-- 
Masami Hiramatsu <mhiramat@...nel.org>