linux-kernel - Re: [PATCH 0/2] KVM: Fix out-of-bounds memslot access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ce021ce6-b4a9-4dab-a063-945fcd9bfcf5@de.ibm.com>
Date:   Wed, 8 Apr 2020 08:55:12 +0200
From:   Christian Borntraeger <borntraeger@...ibm.com>
To:     Sean Christopherson <sean.j.christopherson@...el.com>,
        Janosch Frank <frankja@...ux.ibm.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Cc:     David Hildenbrand <david@...hat.com>,
        Cornelia Huck <cohuck@...hat.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        syzbot+d889b59b2bb87d4047a2@...kaller.appspotmail.com
Subject: Re: [PATCH 0/2] KVM: Fix out-of-bounds memslot access



On 08.04.20 08:40, Sean Christopherson wrote:
> Two fixes for what are effectively the same bug.  The binary search used
> for memslot lookup doesn't check the resolved index and can access memory
> beyond the end of the memslot array.
> 
> I split the s390 specific change to a separate patch because it's subtly
> different, and to simplify backporting.  The KVM wide fix can be applied
> to stable trees as is, but AFAICT the s390 change would need to be paired
> with the !used_slots check from commit 774a964ef56 ("KVM: Fix out of range
> accesses to memslots").  This is why I tagged only the KVM wide patch for
> stable.

You can specify dependencies like

see

Documentation/process/stable-kernel-rules.rst

-----------snip---------------
Additionally, some patches submitted via :ref:`option_1` may have additional
patch prerequisites which can be cherry-picked. This can be specified in the
following format in the sign-off area:

.. code-block:: none

     Cc: <stable@...r.kernel.org> # 3.3.x: a1f84a3: sched: Check for idle
     Cc: <stable@...r.kernel.org> # 3.3.x: 1b9508f: sched: Rate-limit newidle
     Cc: <stable@...r.kernel.org> # 3.3.x: fd21073: sched: Fix affinity logic
     Cc: <stable@...r.kernel.org> # 3.3.x
     Signed-off-by: Ingo Molnar <mingo@...e.hu>

The tag sequence has the meaning of:

.. code-block:: none

     git cherry-pick a1f84a3
     git cherry-pick 1b9508f
     git cherry-pick fd21073
     git cherry-pick <this commit>

-----------snip---------------