linux-kernel - Re: kbuild: do not pass $(KBUILD_CFLAGS) to scripts/mkcompile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Apr 2020 10:00:30 +0200
From:   Sedat Dilek <sedat.dilek@...il.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: kbuild: do not pass $(KBUILD_CFLAGS) to scripts/mkcompile_h

On Tue, Apr 7, 2020 at 8:56 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> Hi Sedat,
>
> On Mon, Apr 6, 2020 at 7:01 PM Sedat Dilek <sedat.dilek@...il.com> wrote:
> >
> > [ Please CC me I am not subscribed to this mailing-list ]
> >
> > Hi,
> >
> > I think with your patch in [1] line #56 can go away, too?
> >
> > [ scripts/mkcompile_h ]
> >
> > 53 # Generate a temporary compile.h
> > 54
> > 55 { echo /\* This file is auto generated, version $VERSION \*/
> > 56   if [ -n "$CONFIG_FLAGS" ] ; then echo "/* $CONFIG_FLAGS */"; fi
>
>
>
> I think the this inserts a comment line
> to make sure compile.h is updated
> when any of CONFIG_SMP, CONFIG_PREEMPT, CONFIG_PREEMPT_RT
> is changed.
>
> So, this is unrelated to my patch at least.
>

I mixed up CONFIG_FLAGS with KBUILD_CFLAGS - my bad.

- sed@ -

>
> > Thanks.
> >
> > Regards,
> > - Sedat -
> >
> > [1] https://patchwork.kernel.org/patch/11473667/
>
>
>
> --
> Best Regards
> Masahiro Yamada