linux-kernel - RE: [PATCH] exfat: remove 'bps' mount-option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <001301d60d39$212ccf10$63866d30$@samsung.com>
Date:   Wed, 8 Apr 2020 09:03:27 +0900
From:   "Namjae Jeon" <namjae.jeon@...sung.com>
To:     "'Tetsuhiro Kohada'" <Kohada.Tetsuhiro@...MitsubishiElectric.co.jp>
Cc:     <Mori.Takahiro@...MitsubishiElectric.co.jp>,
        <motai.hirotaka@...mitsubishielectric.co.jp>,
        "'Sungjong Seo'" <sj1557.seo@...sung.com>,
        <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] exfat: remove 'bps' mount-option

> remount fails because exfat_show_options() returns unsupported option
> 'bps'.
> > # mount -o ro,remount
> > exfat: Unknown parameter 'bps'
> 
> To fix the problem, just remove 'bps' option from exfat_show_options().
> 
> Signed-off-by: Tetsuhiro Kohada
> <Kohada.Tetsuhiro@...MitsubishiElectric.co.jp>
I will apply your patches after setting up exfat git tree.

Thanks for your work!
> ---
>  fs/exfat/super.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/exfat/super.c b/fs/exfat/super.c index
> 2dd62543a4..1b7d2eb034 100644
> --- a/fs/exfat/super.c
> +++ b/fs/exfat/super.c
> @@ -151,7 +151,6 @@ static int exfat_show_options(struct seq_file *m,
> struct dentry *root)
>  		seq_puts(m, ",iocharset=utf8");
>  	else if (sbi->nls_io)
>  		seq_printf(m, ",iocharset=%s", sbi->nls_io->charset);
> -	seq_printf(m, ",bps=%ld", sb->s_blocksize);
>  	if (opts->errors == EXFAT_ERRORS_CONT)
>  		seq_puts(m, ",errors=continue");
>  	else if (opts->errors == EXFAT_ERRORS_PANIC)
> --
> 2.25.0