linux-kernel - Re: [PATCH] virtio: virtio_console: add missing MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e6140ec9728e5695bbd99270f1ed6b60aab8cf48.camel@yandex.ru>
Date:   Wed, 08 Apr 2020 16:17:07 +0300
From:   Alexander Lobakin <bloodyreaper@...dex.ru>
To:     Amit Shah <amit@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sjur Brandeland <sjur.brandeland@...ricsson.com>,
        Rusty Russell <rusty@...tcorp.com.au>,
        virtualization@...ts.linux-foundation.org, stable@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virtio: virtio_console: add missing
 MODULE_DEVICE_TABLE() for rproc serial

On Wed, 2020-03-11 at 15:53 +0100, Amit Shah wrote:
> On Tue, 2020-03-10 at 14:05 +0300, Alexander Lobakin wrote:
> > rproc_serial_id_table lacks an exposure to module devicetable, so
> > when remoteproc firmware requests VIRTIO_ID_RPROC_SERIAL, no uevent
> > is generated and no module autoloading occurs.
> > Add missing MODULE_DEVICE_TABLE() annotation and move the existing
> > one for VIRTIO_ID_CONSOLE right to the table itself.
> > 
> > Fixes: 1b6370463e88 ("virtio_console: Add support for remoteproc
> > serial")
> > Cc: <stable@...r.kernel.org> # v3.8+
> > Signed-off-by: Alexander Lobakin <alobakin@...nk.ru>
> 
> Reviewed-by: Amit Shah <amit@...nel.org>

Thank you! Well, who will take this into his tree?

> Thanks,
> 
> > ---
> >  drivers/char/virtio_console.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/char/virtio_console.c
> > b/drivers/char/virtio_console.c
> > index 4df9b40d6342..7e1bc0f580a2 100644
> > --- a/drivers/char/virtio_console.c
> > +++ b/drivers/char/virtio_console.c
> > @@ -2116,6 +2116,7 @@ static struct virtio_device_id id_table[] = {
> >  	{ VIRTIO_ID_CONSOLE, VIRTIO_DEV_ANY_ID },
> >  	{ 0 },
> >  };
> > +MODULE_DEVICE_TABLE(virtio, id_table);
> >  
> >  static unsigned int features[] = {
> >  	VIRTIO_CONSOLE_F_SIZE,
> > @@ -2128,6 +2129,7 @@ static struct virtio_device_id
> > rproc_serial_id_table[] = {
> >  #endif
> >  	{ 0 },
> >  };
> > +MODULE_DEVICE_TABLE(virtio, rproc_serial_id_table);
> >  
> >  static unsigned int rproc_serial_features[] = {
> >  };
> > @@ -2280,6 +2282,5 @@ static void __exit fini(void)
> >  module_init(init);
> >  module_exit(fini);
> >  
> > -MODULE_DEVICE_TABLE(virtio, id_table);
> >  MODULE_DESCRIPTION("Virtio console driver");
> >  MODULE_LICENSE("GPL");