linux-kernel - Re: [PATCH v1 17/28] i2c: altera: convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <626c205a-2f19-ea80-b817-ab64d51cfff7@linux.intel.com>
Date:   Wed, 8 Apr 2020 08:43:26 -0500
From:   Thor Thayer <thor.thayer@...ux.intel.com>
To:     Dejin Zheng <zhengdejin5@...il.com>, krzysztof.adamski@...ia.com,
        rjui@...adcom.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, f.fainelli@...il.com,
        nsekhar@...com, bgolaszewski@...libre.com,
        jarkko.nikula@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
        mika.westerberg@...ux.intel.com, baruch@...s.co.il,
        wsa+renesas@...g-engineering.com, kgene@...nel.org,
        krzk@...nel.org, paul@...pouillou.net, vz@...ia.com,
        khilman@...libre.com, matthias.bgg@...il.com,
        gregory.clement@...tlin.com, rrichter@...vell.com,
        afaerber@...e.de, manivannan.sadhasivam@...aro.org,
        agross@...nel.org, bjorn.andersson@...aro.org, heiko@...ech.de,
        baohua@...nel.org, linus.walleij@...aro.org, mripard@...nel.org,
        wens@...e.org, ardb@...nel.org, michal.simek@...inx.com,
        gcherian@...vell.com, jun.nie@...aro.org, shawnguo@...nel.org,
        rayagonda.kokatanur@...adcom.com, lori.hikichi@...adcom.com,
        nishkadg.linux@...il.com, kstewart@...uxfoundation.org,
        allison@...utok.net, gregkh@...uxfoundation.org,
        tglx@...utronix.de, bigeasy@...utronix.de, info@...ux.net,
        hslester96@...il.com, narmstrong@...libre.com,
        martin.blumenstingl@...glemail.com, qii.wang@...iatek.com,
        drinkcat@...omium.org, hsinyi@...omium.org, fparent@...libre.com,
        opensource@...ayne.com, swinslow@...il.com,
        linux-i2c@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v1 17/28] i2c: altera: convert to
 devm_platform_ioremap_resource

On 4/7/20 11:37 AM, Dejin Zheng wrote:
> use devm_platform_ioremap_resource() to simplify code, which
> contains platform_get_resource and devm_ioremap_resource.
> 
> Signed-off-by: Dejin Zheng <zhengdejin5@...il.com>

Acked-by: Thor Thayer <thor.thayer@...ux.intel.com>

> ---
>   drivers/i2c/busses/i2c-altera.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-altera.c b/drivers/i2c/busses/i2c-altera.c
> index 1de23b4f3809..7c4c836a3228 100644
> --- a/drivers/i2c/busses/i2c-altera.c
> +++ b/drivers/i2c/busses/i2c-altera.c
> @@ -382,7 +382,6 @@ static const struct i2c_algorithm altr_i2c_algo = {
>   static int altr_i2c_probe(struct platform_device *pdev)
>   {
>   	struct altr_i2c_dev *idev = NULL;
> -	struct resource *res;
>   	int irq, ret;
>   	u32 val;
>   
> @@ -390,8 +389,7 @@ static int altr_i2c_probe(struct platform_device *pdev)
>   	if (!idev)
>   		return -ENOMEM;
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	idev->base = devm_ioremap_resource(&pdev->dev, res);
> +	idev->base = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(idev->base))
>   		return PTR_ERR(idev->base);
>   
>