linux-kernel - Re: [PATCH -next] mm: page_alloc: fix kernel-doc warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKgT0UeGiCvcmEwJ1AL7AP8_ZxAbO9CnVwLzmbKQ9FAMSkJ_ag@mail.gmail.com>
Date:   Wed, 8 Apr 2020 07:54:00 -0700
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, Linux MM <linux-mm@...ck.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] mm: page_alloc: fix kernel-doc warning

On Tue, Apr 7, 2020 at 9:30 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> From: Randy Dunlap <rdunlap@...radead.org>
>
> Add description of function parameter 'mt' to fix kernel-doc warning:
>
> ../mm/page_alloc.c:3246: warning: Function parameter or member 'mt' not described in '__putback_isolated_page'
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Thanks for catching this. The fix looks good to me.

Acked-by: Alexander Duyck <alexander.h.duyck@...ux.intel.com>

> ---
>  mm/page_alloc.c |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20200407.orig/mm/page_alloc.c
> +++ linux-next-20200407/mm/page_alloc.c
> @@ -3238,6 +3238,7 @@ int __isolate_free_page(struct page *pag
>   * __putback_isolated_page - Return a now-isolated page back where we got it
>   * @page: Page that was isolated
>   * @order: Order of the isolated page
> + * @mt: The page's pageblock's migratetype
>   *
>   * This function is meant to return a page pulled from the free lists via
>   * __isolate_free_page back to the free lists they were pulled from.
>
>