linux-kernel - Re: [PATCH v2] vsprintf: don't obfuscate NULL and error pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOi1vP_Dqu7i52_BPmR8N8+svAKMEwqHTOQrNV_228tXo8mHaQ@mail.gmail.com>
Date:   Wed, 8 Apr 2020 17:52:52 +0200
From:   Ilya Dryomov <idryomov@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Rasmus Villemoes <linux@...musvillemoes.dk>,
        Petr Mladek <pmladek@...e.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Kees Cook <keescook@...omium.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        "Tobin C . Harding" <me@...in.cc>
Subject: Re: [PATCH v2] vsprintf: don't obfuscate NULL and error pointers

On Wed, Apr 8, 2020 at 5:06 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Wed, Apr 08, 2020 at 04:38:25PM +0200, Ilya Dryomov wrote:
> > On Wed, Apr 8, 2020 at 12:31 AM Andy Shevchenko
> > <andy.shevchenko@...il.com> wrote:
> > >
> > > On Wed, Apr 8, 2020 at 12:45 AM Ilya Dryomov <idryomov@...il.com> wrote:
> > > > On Wed, Feb 19, 2020 at 8:23 PM Ilya Dryomov <idryomov@...il.com> wrote:
> > >
> > > > Hi Petr,
> > > >
> > > > Bump, as I don't see this in linux-next or other public branches.
> > > > The discussion was split between several threads, revolving around
> > > > the vision for how lib/test_printf.c should be structured, but the
> > > > fix itself wasn't disputed.
> > > >
> > > > Could you please pick it up for 5.7-rc1?  If you want to restructure
> > > > the test suite before adding any new test cases, v1 doesn't have them.
> > > > Other than the test cases, the only difference between v1 and v2 is
> > > > added reviews and acks.
> > >
> > > Petr has some obstacles that prevent him to pay attention on this and
> > > actually do anything right now for Linux kernel.
> > > If Rasmus, Sergey, you and maybe others will got consensus here, I
> > > think Andrew can take it thru his tree.
> >
> > Thanks for letting us know, Andy.
> >
> > Other than Petr, two people are listed as maintainers of vsprintf.c:
> > Sergey and Steve.  Both of them were fine with v1 (no tests) and sent
> > their acks.
> >
> > Rasmus, you wanted to see some tests, so I posted v2.  However Petr
> > wanted to restructure the test suite first, and it didn't seem like you
> > him agreed on what exactly that should look like.  Which would you
> > prefer to be picked by Andrew, v1 or v2?
>
> I think it's question to maintainers. I'm a reviewer here.

This question was directed at Rasmus.  Technically he is also a
reviewer, but I wanted to hear from him because he authored the test
suite in question.

Sergey and Steve (who are a listed as maintainers) were OK with v1
which doesn't touch lib/test_printf.c.

Thanks,

                Ilya