| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAAOTY_8RMboOuKVKPANZ1QN+mt0jvOr13o84VhWKGY1QZqbPDg@mail.gmail.com>
Date: Thu, 9 Apr 2020 00:09:27 +0800
From: Chun-Kuang Hu <chunkuang.hu@...nel.org>
To: Enric Balletbo Serra <eballetbo@...il.com>
Cc: Hsin-Yi Wang <hsinyi@...omium.org>,
Mark Rutland <mark.rutland@....com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
Rob Herring <robh+dt@...nel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@...ts.infradead.org>,
Bibby Hsieh <bibby.hsieh@...iatek.com>,
Matthias Brugger <matthias.bgg@...il.com>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] arm64: dts: mt8173: Add gce setting in mmsys and display node
Hi, Hsin-Yi:
Enric Balletbo Serra <eballetbo@...il.com> 於 2020年4月8日 週三 下午11:48寫道：
>
> Missatge de Hsin-Yi Wang <hsinyi@...omium.org> del dia dl., 18 de nov.
> 2019 a les 11:43:
> >
> > In order to use GCE function, we need add some informations
> > into display node (mboxes, mediatek,gce-client-reg, mediatek,gce-events).
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@...omium.org>
>
> With the fix provided by Hsin-Yi [1] and after the mmsys patches
> landed I get GCE function working on mt8173, so
>
> Tested-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
>
> [1] https://lore.kernel.org/lkml/20200406051131.225748-1-hsinyi@chromium.org/
>
> Thanks,
> Enric
>
> > ---
> > - This is based on series "support gce on mt8183 platform"
> > https://patchwork.kernel.org/cover/11208309/
> > - gce setting in 8183:
> > https://patchwork.kernel.org/patch/11127105/
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 15f1842f6df3..e84ec3f95d81 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -911,6 +911,11 @@ mmsys: clock-controller@...00000 {
> > assigned-clocks = <&topckgen CLK_TOP_MM_SEL>;
> > assigned-clock-rates = <400000000>;
> > #clock-cells = <1>;
> > + mboxes = <&gce 0 CMDQ_THR_PRIO_HIGHEST 1>,
> > + <&gce 1 CMDQ_THR_PRIO_HIGHEST 1>;
Because of patch [1], atomic_exec parameter should be removed.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20200408&id=19d8e335d58a961a7ed377e5e2e63664b92c0b9c
> > + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0 0x1000>;
> > + mediatek,gce-events = <CMDQ_EVENT_MUTEX0_STREAM_EOF>,
> > + <CMDQ_EVENT_MUTEX1_STREAM_EOF>;
Because of patch [2], these events should be moved to mutex node.
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.6&id=60fa8c13ab1a33b8b958efb1510ec2fd8a064bcc
Regards,
Chun-Kuang.
> > };
> >
> > mdp_rdma0: rdma@...01000 {
> > @@ -991,6 +996,7 @@ ovl0: ovl@...0c000 {
> > clocks = <&mmsys CLK_MM_DISP_OVL0>;
> > iommus = <&iommu M4U_PORT_DISP_OVL0>;
> > mediatek,larb = <&larb0>;
> > + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xc000 0x1000>;
> > };
> >
> > ovl1: ovl@...0d000 {
> > @@ -1001,6 +1007,7 @@ ovl1: ovl@...0d000 {
> > clocks = <&mmsys CLK_MM_DISP_OVL1>;
> > iommus = <&iommu M4U_PORT_DISP_OVL1>;
> > mediatek,larb = <&larb4>;
> > + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xd000 0x1000>;
> > };
> >
> > rdma0: rdma@...0e000 {
> > @@ -1011,6 +1018,7 @@ rdma0: rdma@...0e000 {
> > clocks = <&mmsys CLK_MM_DISP_RDMA0>;
> > iommus = <&iommu M4U_PORT_DISP_RDMA0>;
> > mediatek,larb = <&larb0>;
> > + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xe000 0x1000>;
> > };
> >
> > rdma1: rdma@...0f000 {
> > @@ -1021,6 +1029,7 @@ rdma1: rdma@...0f000 {
> > clocks = <&mmsys CLK_MM_DISP_RDMA1>;
> > iommus = <&iommu M4U_PORT_DISP_RDMA1>;
> > mediatek,larb = <&larb4>;
> > + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xf000 0x1000>;
> > };
> >
> > rdma2: rdma@...10000 {
> > @@ -1031,6 +1040,7 @@ rdma2: rdma@...10000 {
> > clocks = <&mmsys CLK_MM_DISP_RDMA2>;
> > iommus = <&iommu M4U_PORT_DISP_RDMA2>;
> > mediatek,larb = <&larb4>;
> > + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0 0x1000>;
> > };
> >
> > wdma0: wdma@...11000 {
> > @@ -1041,6 +1051,7 @@ wdma0: wdma@...11000 {
> > clocks = <&mmsys CLK_MM_DISP_WDMA0>;
> > iommus = <&iommu M4U_PORT_DISP_WDMA0>;
> > mediatek,larb = <&larb0>;
> > + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x1000 0x1000>;
> > };
> >
> > wdma1: wdma@...12000 {
> > @@ -1051,6 +1062,7 @@ wdma1: wdma@...12000 {
> > clocks = <&mmsys CLK_MM_DISP_WDMA1>;
> > iommus = <&iommu M4U_PORT_DISP_WDMA1>;
> > mediatek,larb = <&larb4>;
> > + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x2000 0x1000>;
> > };
> >
> > color0: color@...13000 {
> > @@ -1059,6 +1071,7 @@ color0: color@...13000 {
> > interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_LOW>;
> > power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> > clocks = <&mmsys CLK_MM_DISP_COLOR0>;
> > + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x3000 0x1000>;
> > };
> >
> > color1: color@...14000 {
> > @@ -1067,6 +1080,7 @@ color1: color@...14000 {
> > interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_LOW>;
> > power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> > clocks = <&mmsys CLK_MM_DISP_COLOR1>;
> > + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x4000 0x1000>;
> > };
> >
> > aal@...15000 {
> > @@ -1075,6 +1089,7 @@ aal@...15000 {
> > interrupts = <GIC_SPI 189 IRQ_TYPE_LEVEL_LOW>;
> > power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> > clocks = <&mmsys CLK_MM_DISP_AAL>;
> > + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x5000 0x1000>;
> > };
> >
> > gamma@...16000 {
> > @@ -1083,6 +1098,7 @@ gamma@...16000 {
> > interrupts = <GIC_SPI 190 IRQ_TYPE_LEVEL_LOW>;
> > power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> > clocks = <&mmsys CLK_MM_DISP_GAMMA>;
> > + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x6000 0x1000>;
> > };
> >
> > merge@...17000 {
> > --
> > 2.24.0.432.g9d3f5f5b63-goog
> >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@...ts.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
Powered by blists - more mailing lists