linux-kernel - Re: [PATCH] of: remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94145488-c077-4b40-943f-f53f21f660c4@gmail.com>
Date:   Wed, 8 Apr 2020 14:27:11 -0500
From:   Frank Rowand <frowand.list@...il.com>
To:     Ding Xiang <dingxiang@...s.chinamobile.com>, robh+dt@...nel.org
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: remove unneeded variable

On 4/8/20 11:00 AM, Frank Rowand wrote:
> On 3/30/20 5:05 AM, Ding Xiang wrote:
>> rc is unneeded, just return 0.
> 
> of: of_detach_node() remove unneeded local return variable

never mind, this is not the subject line...  My mistake.

-Frank

> 
>>
>> Signed-off-by: Ding Xiang <dingxiang@...s.chinamobile.com>
>> ---
>>  drivers/of/dynamic.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
>> index 08fd823..fe64430 100644
>> --- a/drivers/of/dynamic.c
>> +++ b/drivers/of/dynamic.c
>> @@ -286,7 +286,6 @@ int of_detach_node(struct device_node *np)
>>  {
>>  	struct of_reconfig_data rd;
>>  	unsigned long flags;
>> -	int rc = 0;
>>  
>>  	memset(&rd, 0, sizeof(rd));
>>  	rd.dn = np;
>> @@ -301,7 +300,7 @@ int of_detach_node(struct device_node *np)
>>  
>>  	of_reconfig_notify(OF_RECONFIG_DETACH_NODE, &rd);
>>  
>> -	return rc;
>> +	return 0;
>>  }
>>  EXPORT_SYMBOL_GPL(of_detach_node);
>>  
>>
> 
> 
> Reviewed-by: Frank Rowand <frank.rowand@...y.com>
>