linux-kernel - Re: [RFC 1/1] net/mlx5: Fix failing fw tracer allocation on s390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Apr 2020 19:36:07 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "schnelle@...ux.ibm.com" <schnelle@...ux.ibm.com>,
        Feras Daoud <ferasda@...lanox.com>,
        Alex Vesker <valex@...lanox.com>
CC:     Eran Ben Elisha <eranbe@...lanox.com>,
        Moshe Shemesh <moshe@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "leon@...nel.org" <leon@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC 1/1] net/mlx5: Fix failing fw tracer allocation on s390

On Tue, 2020-04-07 at 10:01 +0200, Niklas Schnelle wrote:
> On s390 FORCE_MAX_ZONEORDER is 9 instead of 11, thus a larger
> kzalloc()
> allocation as done for the firmware tracer will always fail.
> 
> Looking at mlx5_fw_tracer_save_trace(), it is actually the driver
> itself
> that copies the debug data into the trace array and there is no need
> for
> the allocation to be contiguous in physical memory. We can therefor
> use
> kvzalloc() instead of kzalloc() and get rid of the large contiguous
> allcoation.
> 

This looks fine and very straight forward.. i don't expect any issue
with this.

Please provide a proper "Fixes:" tag and resubmit to net without the
[RFC].

Thanks