linux-kernel - Re: [RFC] net/mlx5: Fix failing fw tracer allocation on s390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bf22d830013fcdae7b955ac687d96437cd21cc19.camel@mellanox.com>
Date:   Wed, 8 Apr 2020 19:38:51 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "Markus.Elfring@....de" <Markus.Elfring@....de>,
        "schnelle@...ux.ibm.com" <schnelle@...ux.ibm.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Eran Ben Elisha <eranbe@...lanox.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "leon@...nel.org" <leon@...nel.org>,
        Moshe Shemesh <moshe@...lanox.com>
Subject: Re: [RFC] net/mlx5: Fix failing fw tracer allocation on s390

On Wed, 2020-04-08 at 10:06 +0200, Niklas Schnelle wrote:
> On 4/7/20 5:12 PM, Markus Elfring wrote:
> > > On s390 FORCE_MAX_ZONEORDER is 9 instead of 11, thus a larger
> > > kzalloc()
> > > allocation as done for the firmware tracer will always fail.
> > 
> > How do you think about to add the tag “Fixes” to the final change
> > description?
> > 
> > Regards,
> > Markus
> > 
> You're right that makes a lot of sense, thanks! I guess this should
> reference
> the commit that introduced the debug trace, right?
> 

probably, just git blame this line:
  tracer = kzalloc(sizeof(*tracer), GFP_KERNEL);