linux-kernel - Re: virtio-mmio: Delete an error message in vm_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c94db13-ae46-cf8e-f3c4-6f270112ad87@redhat.com>
Date:   Thu, 9 Apr 2020 14:20:38 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Markus Elfring <Markus.Elfring@....de>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        virtualization@...ts.linux-foundation.org
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Andrzej Hajda <a.hajda@...sung.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Javier Martinez Canillas <javierm@...hat.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Mark Brown <broonie@...nel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Rob Herring <robh@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        Stephen Boyd <swboyd@...omium.org>,
        Tang Bin <tangbin@...s.chinamobile.com>
Subject: Re: virtio-mmio: Delete an error message in vm_find_vqs()


On 2020/4/9 下午2:02, Markus Elfring wrote:
>>> The function “platform_get_irq” can log an error already.
>>> Thus omit a redundant message for the exception handling in the
>>> calling function.
>> It looks to me that not all error path of platform_get_irq() were loggd.
> How do you think about to clarify the handling of the error code “-EPROBE_DEFER” any more?
> https://elixir.bootlin.com/linux/v5.6.3/source/drivers/base/platform.c#L202


Aha, it looks to me that I'm on the wrong branch. Sorry.


>
>
>> And git grep told me there're other users of platform_get_irq() that check and log by themselves.
> Source code analysis can point further update candidates out, can't it?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/base/platform.c?id=7723f4c5ecdb8d832f049f8483beb0d1081cedf6


Yes, it can.


>
> Would you like to achieve collateral evolution?


Yes and it's probably be better to put all the fixes in one series.

For this patch.

Acked-by: Jason Wang <jasowang@...hat.com>

Thanks


>
> Regards,
> Markus
>