linux-kernel - Re: [PATCH] MIPS: Limit check_bugs32() under CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200409150923.5b224361@flygoat-x1e>
Date:   Thu, 9 Apr 2020 15:09:23 +0800
From:   Jiaxun Yang <jiaxun.yang@...goat.com>
To:     YunQiang Su <wzssyqa@...il.com>
Cc:     Tiezhu Yang <yangtiezhu@...ngson.cn>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-mips <linux-mips@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Xuefeng Li <lixuefeng@...ngson.cn>
Subject: Re: [PATCH] MIPS: Limit check_bugs32() under CONFIG_32BIT

On Thu, 9 Apr 2020 12:43:28 +0800
YunQiang Su <wzssyqa@...il.com> wrote:

> Tiezhu Yang <yangtiezhu@...ngson.cn> 于2020年4月9日周四
> 上午11:10写道：
> >
> > There is no need to build and call check_bugs32() under
> > CONFIG_64BIT, just limit it under CONFIG_32BIT.  
> 
> Since 32bit is subset of 64bit, and due to the code, I think that the
> initial purpose
> of check_bugs32() is also willing to run even with CONFIG_64BIT.
> 
> For example, if we have a CPU which is 64bit, and work well on 64bit
> mode, while has a bug only on 32bit mode, check_bugs32 should be used
> here.
> 
> Loongson's 3A 1000 is the example, I cannot support FP32 mode well.

In this case bugs32 only contains a workaround for MIPS34K, which is a
MIPS32 processor. It's safe to do so.

But my suggestion is if you're going to clean-up bugs and workarounds
you'd better establish a file for silicon bugs and provide Kconfig
options to enable & disable them. Manage bug dependencies by Kconfig
will be easier.

Thanks.

--
Jiaxun Yang