linux-kernel - Re: [PATCH v5 05/10] mm/swap: charge the page when adding to the swap cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAAmzW4MANwv6OS646Tkbvs1Db+kn6f2=WDJHi9EAXsz0vp1sXA@mail.gmail.com>
Date:   Thu, 9 Apr 2020 09:53:59 +0900
From:   Joonsoo Kim <js1304@...il.com>
To:     Hillf Danton <hdanton@...a.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Michal Hocko <mhocko@...nel.org>,
        Hugh Dickins <hughd@...gle.com>,
        Minchan Kim <minchan@...nel.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Mel Gorman <mgorman@...hsingularity.net>
Subject: Re: [PATCH v5 05/10] mm/swap: charge the page when adding to the swap cache

2020년 4월 7일 (화) 오전 11:21, Hillf Danton <hdanton@...a.com>님이 작성:
>
>
> On Tue, 7 Apr 2020 09:42:54 +0900 Joonsoo Kim wrote:
> >
> > 2020=EB=85=84 4=EC=9B=94 6=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 8:58, Hi=
> > llf Danton <hdanton@...a.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
> > >
> > >
> > > On Fri,  3 Apr 2020 14:40:43 +0900 Joonsoo Kim wrote:
> > > >
> > > > @@ -153,11 +165,16 @@ int add_to_swap_cache(struct page *page, swp_entr=
> > y_t entry,
> > > >               xas_unlock_irq(&xas);
> > > >       } while (xas_nomem(&xas, gfp));
> > > >
> > > > -     if (!xas_error(&xas))
> > > > +     if (!xas_error(&xas)) {
> > > > +             mem_cgroup_commit_charge(page, memcg, false, compound);
> > >
> > > Add a tp
> > >                 trace_mm_add_to_swap_cache(page);
> >
> > Please let me know the reason of this comment.
>
> It is derived from
>
>         trace_mm_filemap_add_to_page_cache(page);
>
> in __add_to_page_cache_locked().

Maybe, it has it's own purpose and it would not be applied here. If
someone want to add
a tp here, it can be done with a justification, after this patchset.

Thanks.