linux-kernel - Re: [PATCH v1] staging: fbtft: fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200409101416.GN2001@kadam>
Date:   Thu, 9 Apr 2020 13:14:16 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Oliver Graute <oliver.graute@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-fbdev@...r.kernel.org,
        Oliver Graute <oliver.graute@...oconnector.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion

On Thu, Apr 09, 2020 at 11:24:05AM +0200, Oliver Graute wrote:
> From: Oliver Graute <oliver.graute@...oconnector.com>
> 
> Enable inversion mode
> 
> Signed-off-by: Oliver Graute <oliver.graute@...oconnector.com>
> ---
>  drivers/staging/fbtft/fb_st7789v.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft/fb_st7789v.c
> index 3c3f387936e8..84c5af2dc9a0 100644
> --- a/drivers/staging/fbtft/fb_st7789v.c
> +++ b/drivers/staging/fbtft/fb_st7789v.c
> @@ -120,6 +120,10 @@ static int init_display(struct fbtft_par *par)
>  	write_reg(par, PWCTRL1, 0xA4, 0xA1);
>  
>  	write_reg(par, MIPI_DCS_SET_DISPLAY_ON);
> +
> +	/* enable inversion mode */
> +	write_reg(par, 0x21);

Use the define and delete the comment.

	write_reg(par, MIPI_DCS_ENTER_INVERT_MODE);

regards,
dan carpenter