linux-kernel - Re: [PATCH] irqchip/ti-sci-inta: fix processing of masked irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200409121743.10bbcc9a@why>
Date:   Thu, 9 Apr 2020 12:17:43 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Grygorii Strashko <grygorii.strashko@...com>
Cc:     Nishanth Menon <nm@...com>, Peter Ujfalusi <peter.ujfalusi@...com>,
        Jason Cooper <jason@...edaemon.net>,
        Lokesh Vutla <lokeshvutla@...com>,
        Sekhar Nori <nsekhar@...com>, <linux-kernel@...r.kernel.org>,
        Tero Kristo <t-kristo@...com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        <linux-arm-kernel@...ts.infradead.org>,
        Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH] irqchip/ti-sci-inta: fix processing of masked irqs

On Thu, 9 Apr 2020 14:11:12 +0300
Grygorii Strashko <grygorii.strashko@...com> wrote:

> On 09/04/2020 12:31, Marc Zyngier wrote:
> > On Wed, 8 Apr 2020 22:15:32 +0300
> > Grygorii Strashko <grygorii.strashko@...com> wrote:
> >   
> >> The ti_sci_inta_irq_handler() does not take into account INTA IRQs state
> >> (masked/unmasked) as it uses INTA_STATUS_CLEAR_j register to get INTA IRQs
> >> status, which provides raw status value.
> >> This causes hard IRQ handlers to be called or threaded handlers to be
> >> scheduled many times even if corresponding INTA IRQ is masked.
> >> Above, first of all, affects the LEVEL interrupts processing and causes
> >> unexpected behavior up the system stack or crash.
> >>
> >> Fix it by using the Interrupt Masked Status INTA_STATUSM_j register which
> >> provides masked INTA IRQs status.
> >>
> >> Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver")
> >> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>  
> > 
> > Given the failure mode, doesn't this deserve a Cc stable?  
> 
> Sorry, was not sure how it works here.
> "Fixes" tag now is usually enough to get included in stable.
> Any way, I'll track it and if not included will re-send for stable.

Last time I asked, Greg was adamant that a Cc: stable was needed to
guarantee a backport. In some cases, the patch is picked up anyway, but
it doesn't hurt to have the stable tag if you think it should be
backported.

Anyway, I've now added such tag.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...