linux-kernel - Re: [PATCH v3 4/4] usb: host: Add ability to build new Broadcom STB USB drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200409123005.GZ3676135@smile.fi.intel.com>
Date:   Thu, 9 Apr 2020 15:30:05 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Alan Cooper <alcooperx@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Alan Stern <stern@...land.harvard.edu>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        devicetree <devicetree@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jonathan Neuschäfer <j.neuschaefer@....net>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        USB <linux-usb@...r.kernel.org>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v3 4/4] usb: host: Add ability to build new Broadcom STB
 USB drivers

On Thu, Apr 09, 2020 at 07:49:52AM -0400, Alan Cooper wrote:
> On Thu, Apr 9, 2020 at 5:08 AM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> >
> > On Thu, Apr 9, 2020 at 12:52 AM Al Cooper <alcooperx@...il.com> wrote:
> > >
> > > Add the build system changes needed to get the Broadcom STB XHCI,
> > > EHCI and OHCI functionality working. The OHCI support does not
> > > require anything unique to Broadcom so the standard ohci-platform
> > > driver is being used. The link order for XHCI was changed in the
> > > Makefile because of the way STB XHCI, EHCI and OHCI controllers
> > > share a port which requires that the XHCI driver be initialized
> > > first. Also update MAINTAINERS.
> >
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -3477,6 +3477,14 @@ S:       Supported
> > >  F:     drivers/i2c/busses/i2c-brcmstb.c
> > >  F:     Documentation/devicetree/bindings/i2c/brcm,brcmstb-i2c.yaml
> > >
> > > +BROADCOM BRCMSTB USB EHCI DRIVER
> > > +M:     Al Cooper <alcooperx@...il.com>
> > > +L:     linux-usb@...r.kernel.org
> > > +L:     bcm-kernel-feedback-list@...adcom.com
> > > +S:     Maintained
> > > +F:     drivers/usb/host/ehci-brcm.*
> > > +F:     Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml
> >
> > This has ordering issues.
> > Run parse-maintainer.pl to fix. (Note, it creates by default a new
> > file, you might need to run diff manually to see the difference).
> 
> I'm not sure what you mean.
> I ran "./scripts/parse-maintainers.pl" and did "diff MAINTAINERS
> MAINTAINERS.new" and there are no differences in or around my entry.

Perhaps --order should be added.

-- 
With Best Regards,
Andy Shevchenko