linux-kernel - Re: [PATCH] phy: tegra: fix USB dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Apr 2020 15:24:35 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Corentin Labbe <clabbe@...libre.com>,
        Nagarjuna Kristam <nkristam@...dia.com>,
        Thierry Reding <treding@...dia.com>,
        Vidya Sagar <vidyas@...dia.com>, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH] phy: tegra: fix USB dependencies

On Wed, Apr 08, 2020 at 10:08:14PM +0200, Arnd Bergmann wrote:
> Without CONFIG_USB_SUPPORT, we can get a couple of warnings for
> missing dependencies:
> 
> WARNING: unmet direct dependencies detected for USB_PHY
>   Depends on [n]: USB_SUPPORT [=n]
>   Selected by [m]:
>   - PHY_TEGRA_XUSB [=m] && ARCH_TEGRA [=y]
> 
> WARNING: unmet direct dependencies detected for USB_CONN_GPIO
>   Depends on [n]: USB_SUPPORT [=n] && GPIOLIB [=y]
>   Selected by [m]:
>   - PHY_TEGRA_XUSB [=m] && ARCH_TEGRA [=y]
> 
> Fixes: 6835bdc99580 ("phy: tegra: Select USB_PHY")
> Fixes: f67213cee2b3 ("phy: tegra: xusb: Add usb-role-switch support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/phy/tegra/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I sent a similar patch a couple of days ago:

	http://patchwork.ozlabs.org/patch/1263865/

This should be applied by Greg on top of the PR that I sent for USB. I
did get the semi-automated "we're in the merge window" reply from Greg,
but I was under the impression that he still applied fixes during the
merge window. It seems like he didn't pick this up yet, though.

Greg, anything I should've done differently for you to notice this?

Thierry

> diff --git a/drivers/phy/tegra/Kconfig b/drivers/phy/tegra/Kconfig
> index a208aca4ba7b..4f8c61863411 100644
> --- a/drivers/phy/tegra/Kconfig
> +++ b/drivers/phy/tegra/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config PHY_TEGRA_XUSB
>  	tristate "NVIDIA Tegra XUSB pad controller driver"
> -	depends on ARCH_TEGRA
> +	depends on ARCH_TEGRA && USB_SUPPORT
>  	select USB_CONN_GPIO
>  	select USB_PHY
>  	help
> -- 
> 2.26.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)