linux-kernel - Re: [PATCH] soc: tegra: fix tegra_pmc_get_suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200409150231.GB3505571@ulmo>
Date:   Thu, 9 Apr 2020 17:02:31 +0200
From:   Thierry Reding <treding@...dia.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     <soc@...nel.org>, Thierry Reding <thierry.reding@...il.com>,
        "Jonathan Hunter" <jonathanh@...dia.com>,
        Dmitry Osipenko <digetx@...il.com>,
        "Daniel Lezcano" <daniel.lezcano@...aro.org>,
        Peter De Schrijver <pdeschrijver@...dia.com>,
        Venkat Reddy Talla <vreddytalla@...dia.com>,
        <linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc: tegra: fix tegra_pmc_get_suspend_mode definition

On Wed, Apr 08, 2020 at 09:01:15PM +0200, Arnd Bergmann wrote:
> When CONFIG_PM_SLEEP is disabled, the function is not defined,
> causing a link failure:
> 
> arm-linux-gnueabi-ld: drivers/cpuidle/cpuidle-tegra.o: in function `tegra_cpuidle_probe':
> cpuidle-tegra.c:(.text+0x24): undefined reference to `tegra_pmc_get_suspend_mode'
> 
> Change the #ifdef check according to the definition.
> 
> Fixes: 382ac8e22b90 ("cpuidle: tegra: Disable CC6 state if LP2 unavailable")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  include/soc/tegra/pmc.h | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)

Acked-by: Thierry Reding <treding@...dia.com>

Let me know if you'd prefer me to send this in a pull request later on.

Thanks,
Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)